Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖 Sync from open-cluster-management-io/config-policy-controller: #100 #412

Merged
merged 2 commits into from
Feb 4, 2023

Conversation

magic-mirror-bot[bot]
Copy link

@magic-mirror-bot magic-mirror-bot bot commented Feb 3, 2023

When a hosted cluster is removed from OCM, it triggers the hosted cluster
instance of the config-policy-controller to be uninstalled on the hosting cluster.

If any ConfigurationPolicy uses pruneObjectBehavior, they will have finalizers set
on them. During an uninstall, the finalizers are immediately removed on the next
evaluation of the ConfigurationPolicy with pruneObjectBehavior set so that the
uninstall can proceed immediately.

The issue is if the ConfigurationPolicy sets evaluationInterval to a long value,
the finalizer won't be removed until the next evaluation time, which could be hours.

This is not an issue when it's not deployed in hosted mode because the CRD is also
deleted at the same time, which causes the ConfigurationPolicy to have a
deletionTimestamp which then causes immediate evaluation for the finalizer to
be removed.

Relates:
https://issues.redhat.com/browse/ACM-3233

Signed-off-by: mprahl <mprahl@users.noreply.github.com>
(cherry picked from commit eb8f720)
Without this commit, as soon as a SIGINT signal was received, mgr.Start
would exit and cause the main function to finish before
PeriodicallyExecConfigPolicies could finish the removal of finalizers
when the config-policy-controller is being uninstalled.

Co-authored-by: Justin Kulikauskas <jkulikau@redhat.com>
Signed-off-by: mprahl <mprahl@users.noreply.github.com>
(cherry picked from commit 82a7f86)
@mprahl
Copy link
Contributor

mprahl commented Feb 4, 2023

There is a flaky test that is fixed here:
open-cluster-management-io/config-policy-controller#102

I'll retry the flaky test until this merges so that I can wait for a review on the flaky test fix on Monday.

@openshift-ci
Copy link

openshift-ci bot commented Feb 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: magic-mirror-bot[bot], mprahl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Feb 4, 2023
@sonarcloud
Copy link

sonarcloud bot commented Feb 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

87.5% 87.5% Coverage
0.0% 0.0% Duplication

@openshift-merge-robot openshift-merge-robot merged commit a41a5ca into main Feb 4, 2023
@openshift-merge-robot openshift-merge-robot deleted the magic-mirror-main-1675465168287 branch February 4, 2023 18:57
@mprahl
Copy link
Contributor

mprahl commented Feb 4, 2023

/cherry-pick release-2.7

@openshift-cherrypick-robot

@mprahl: new pull request created: #415

In response to this:

/cherry-pick release-2.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

😿 Failed to sync the upstream PRs: #100
3 participants